Bump winit to 0.30.0 and accesskit to 0.14.0 #4466

AndriBaal · 2024-05-06T09:59:28Z

Closes Update to winit 0.30 #4437
Closes Update accesskit_winit #4219
Blocked by feat: Winit 0.30.0 rust-windowing/glutin#1675

Here is a summary of the changes I made:

Bump accesskit to version 0.14.0
Bump winit to 0.30.0
Partially done the glow integration
Roughly implemented accesskit
Implemented winit / wgpu

Here is a summary of things that need to be done:

Integration with glow (have to wait until glutin-winit updates to winit 0.30.0)
Not all accesskit_winit::Event are being processed, temporarily I have marked them with todo!() (found in winit_integration.rs)
Move from deprecated winit::EventLoop::run_on_demand
Documentation and testing
Code review

Babakinha · 2024-06-09T01:11:56Z

Hey, looks like we are no longer blocked by rust-windowing/glutin#1675 bcs rust-windowing/glutin#1678 got merged :3

…and updated / implemented accesskit

AndriBaal · 2024-06-10T16:38:27Z

Thanks for the reminder. I managed to get the hello world example running on x11 with glutin.

Quick summary of my changes:

Updated and implemented accesskit like mentioned here
Updated glutin and glutin-winit to newest version
Removed rwh5 since glutin now support rhw6
Fixed compiling issues on x11

TODO:

Move from deprecated event_loop.run_on_demand and event_loop.run
Test accesskit (I have only copied from the mentioned comment and not tested it in depth by myself)
Test on different plattforms (I only tested it on x11)
Fix egui_glow pure_glowexample

DataTriny · 2024-06-10T16:58:58Z

I have tested the AccessKit integration on Windows and Linux/X11 and it seem to be fine. However I got the following warnings:

warning: use of deprecated method `winit::platform::run_on_demand::EventLoopExtRunOnDemand::run_on_demand`: use EventLoopExtRunOnDemand::run_app_on_demand
  --> crates\eframe\src\native\run.rs:76:16
   |
76 |     event_loop.run_on_demand(|event, event_loop_window_target| {
   |                ^^^^^^^^^^^^^
   |
   = note: `#[warn(deprecated)]` on by default

warning: use of deprecated method `winit::platform::run_on_demand::EventLoopExtRunOnDemand::run_on_demand`: use EventLoopExtRunOnDemand::run_app_on_demand
   --> crates\eframe\src\native\run.rs:225:14
    |
225 |             .run_on_demand(|_, event_loop_window_target| {
    |              ^^^^^^^^^^^^^

warning: use of deprecated method `winit::event_loop::EventLoop::<T>::run`: use `EventLoop::run_app` instead
   --> crates\eframe\src\native\run.rs:244:16
    |
244 |     event_loop.run(move |event, event_loop_window_target| {
    |                ^^^

Compiling the hello_world example on macOS failed with these errors though:

error[E0432]: unresolved import `winit::platform::macos::WindowBuilderExtMacOS`
    --> crates/egui-winit/src/lib.rs:1712:13
     |
1712 |         use winit::platform::macos::WindowBuilderExtMacOS as _;
     |             ^^^^^^^^^^^^^^^^^^^^^^^^---------------------^^^^^
     |             |                       |
     |             |                       help: a similar name exists in the module: `WindowExtMacOS`
     |             no `WindowBuilderExtMacOS` in `platform::macos`

error[E0599]: no method named `with_title_hidden` found for struct `WindowAttributes` in the current scope
    --> crates/egui-winit/src/lib.rs:1714:14
     |
1713 |           window_attributes = window_attributes
     |  _____________________________-
1714 | |             .with_title_hidden(!_title_shown.unwrap_or(true))
     | |_____________-^^^^^^^^^^^^^^^^^
     |
    ::: /Users/Arnold/.cargo/registry/src/index.crates.io-6f17d22bba15001f/winit-0.30.0/src/platform/macos.rs:200:8
     |
200  |       fn with_title_hidden(self, title_hidden: bool) -> Self;
     |          ----------------- the method is available for `WindowAttributes` here
     |
     = help: items from traits can only be used if the trait is in scope
help: the following trait is implemented but not in scope; perhaps add a `use` for it:
     |
12   + use winit::platform::macos::WindowAttributesExtMacOS;
     |
help: there is a method with a similar name
     |
1714 |             .with_title(!_title_shown.unwrap_or(true))
     |              ~~~~~~~~~~

Hope this helps.

AndriBaal · 2024-06-10T20:09:27Z

Yes, the warnings are expected as I mentioned here: Move from deprecated event_loop.run_on_demand and event_loop.run. These methods are deprecated due to the new app API by winit 0.30. I believe that major changes need to be made to the core of eframe to support the new winit app API and I don't know if I'm familiar enough with egui to do such a refactor.

Thanks for testing on macOS. I think I fixed the errors, fell free to pull and try again :)

DataTriny · 2024-06-10T20:54:01Z

It now compiles on macOS. I've tested accessibility on this platform as well. Thanks!

* Closes #1918 * Closes #4437 * Closes #4709 * [x] I have followed the instructions in the PR template Hiya, I need new winit for a specific fix for a android_native_actvity. There are already two PRs, but both don't seem to have a lot of movement, or are entirely complete: #4466 Seems to have gone stale & is missing some bits. #4702 Also seems stale (if less so), and is missing a refactor to run_on_demand. I also *think* the accesskit integration has a mistake and can't be enabled. I've marked them as a co-author on this as I started from this branch. (I think! Haven't done that on git before...). Sorry for the wall of text but just dumping some details / thoughts here: - There's an issue with creating child windows in winit 0.30.1 and up on macOS. The multiple_viewports, "create immediate viewport" example crashes on anything later 0.30.1, with a stack overflow in unsafe code. I've create [a winit issue](rust-windowing/winit#3800), it *might* already be fixed in 0.31.0 but I can't test as 0.31 will likely require another refactoring. For now I have just pinned things to 0.30.0 exatly. - Winit has deprecated run_on_demand, instead requiring the ApplicationHandler interface. In 0.31.0 run_on_demand is removed. I've refactored both the integration and the WinitApp trait to follow this pattern. I've left user_events a bit more opaque, as it seems 0.31.0 is doing a rework of UserEvents too. - I've used the new lazy init approach for access kit from this branch https://github.com/mwcampbell/egui/tree/accesskit-new-lazy-init and marked Matt as co-author, thanks Matt! - There was very similair but not quite the same code for run_and_return and run_and_exit. I've merged them, but looking at the github issues graveyard it seems vey finnicky. I *hope* this is more robust than before but it's a bit scary. - when receiving new_events this also used to check the redraw timing dictionary. That doesn't seem necesarry so left this out, but that is a slight behaviour change? - I have reeneabled serial_windows on macOS. I wondered whether it was fixed after this PR and does seem to be! However, even before this PR it seems to work, so maybe winit has sorted things out before that... Windows also works fine now without the extra hack. - I've done a very basic test of AccessKit on Windows and screen reader seems ok but I'm really not knowleadgable enough to say whether it's all good or not. - I've tested cargo tests & all examples on Windows & macOS, and ran a basic Android app. Still, testing native platforms is wel... hard so if anyone can test linux / iOs / older mac versions / windows 10 would probably be a good idea! - For consistencys sake I've made all event like functions in WinitApp return a `Result<EventResult>`. There's quite a bit of Ok-wrapping now, maybe too annoying? Not sure. Thank you for having a look! # Tested on * [x] macOS * [x] Windows * [x] Wayland (thanks [SiebenCorgie](https://github.com/SiebenCorgie)) * [x] X11 (thanks [crumblingstatue](https://github.com/crumblingstatue)!, [SiebenCorgie](https://github.com/SiebenCorgie)) # TODO * [x] Fix "follow system theme" not working on initial startup (winit issue, pinning to 0.30.2 for now). * [x] Fix `request_repaint_after` --------- Co-authored-by: mwcampbell <mattcampbell@pobox.com> Co-authored-by: j-axa <josef.axa@gmail.com> Co-authored-by: DataTriny <datatriny@gmail.com> Co-authored-by: Emil Ernerfeldt <emil.ernerfeldt@gmail.com>

emilk · 2024-07-31T07:43:50Z

Closed by Upgrade winit to 0.30.2 #4849

* Closes emilk#1918 * Closes emilk#4437 * Closes emilk#4709 * [x] I have followed the instructions in the PR template Hiya, I need new winit for a specific fix for a android_native_actvity. There are already two PRs, but both don't seem to have a lot of movement, or are entirely complete: emilk#4466 Seems to have gone stale & is missing some bits. emilk#4702 Also seems stale (if less so), and is missing a refactor to run_on_demand. I also *think* the accesskit integration has a mistake and can't be enabled. I've marked them as a co-author on this as I started from this branch. (I think! Haven't done that on git before...). Sorry for the wall of text but just dumping some details / thoughts here: - There's an issue with creating child windows in winit 0.30.1 and up on macOS. The multiple_viewports, "create immediate viewport" example crashes on anything later 0.30.1, with a stack overflow in unsafe code. I've create [a winit issue](rust-windowing/winit#3800), it *might* already be fixed in 0.31.0 but I can't test as 0.31 will likely require another refactoring. For now I have just pinned things to 0.30.0 exatly. - Winit has deprecated run_on_demand, instead requiring the ApplicationHandler interface. In 0.31.0 run_on_demand is removed. I've refactored both the integration and the WinitApp trait to follow this pattern. I've left user_events a bit more opaque, as it seems 0.31.0 is doing a rework of UserEvents too. - I've used the new lazy init approach for access kit from this branch https://github.com/mwcampbell/egui/tree/accesskit-new-lazy-init and marked Matt as co-author, thanks Matt! - There was very similair but not quite the same code for run_and_return and run_and_exit. I've merged them, but looking at the github issues graveyard it seems vey finnicky. I *hope* this is more robust than before but it's a bit scary. - when receiving new_events this also used to check the redraw timing dictionary. That doesn't seem necesarry so left this out, but that is a slight behaviour change? - I have reeneabled serial_windows on macOS. I wondered whether it was fixed after this PR and does seem to be! However, even before this PR it seems to work, so maybe winit has sorted things out before that... Windows also works fine now without the extra hack. - I've done a very basic test of AccessKit on Windows and screen reader seems ok but I'm really not knowleadgable enough to say whether it's all good or not. - I've tested cargo tests & all examples on Windows & macOS, and ran a basic Android app. Still, testing native platforms is wel... hard so if anyone can test linux / iOs / older mac versions / windows 10 would probably be a good idea! - For consistencys sake I've made all event like functions in WinitApp return a `Result<EventResult>`. There's quite a bit of Ok-wrapping now, maybe too annoying? Not sure. Thank you for having a look! * [x] macOS * [x] Windows * [x] Wayland (thanks [SiebenCorgie](https://github.com/SiebenCorgie)) * [x] X11 (thanks [crumblingstatue](https://github.com/crumblingstatue)!, [SiebenCorgie](https://github.com/SiebenCorgie)) * [x] Fix "follow system theme" not working on initial startup (winit issue, pinning to 0.30.2 for now). * [x] Fix `request_repaint_after` --------- Co-authored-by: mwcampbell <mattcampbell@pobox.com> Co-authored-by: j-axa <josef.axa@gmail.com> Co-authored-by: DataTriny <datatriny@gmail.com> Co-authored-by: Emil Ernerfeldt <emil.ernerfeldt@gmail.com>

* Closes emilk#1918 * Closes emilk#4437 * Closes emilk#4709 * [x] I have followed the instructions in the PR template Hiya, I need new winit for a specific fix for a android_native_actvity. There are already two PRs, but both don't seem to have a lot of movement, or are entirely complete: emilk#4466 Seems to have gone stale & is missing some bits. emilk#4702 Also seems stale (if less so), and is missing a refactor to run_on_demand. I also *think* the accesskit integration has a mistake and can't be enabled. I've marked them as a co-author on this as I started from this branch. (I think! Haven't done that on git before...). Sorry for the wall of text but just dumping some details / thoughts here: - There's an issue with creating child windows in winit 0.30.1 and up on macOS. The multiple_viewports, "create immediate viewport" example crashes on anything later 0.30.1, with a stack overflow in unsafe code. I've create [a winit issue](rust-windowing/winit#3800), it *might* already be fixed in 0.31.0 but I can't test as 0.31 will likely require another refactoring. For now I have just pinned things to 0.30.0 exatly. - Winit has deprecated run_on_demand, instead requiring the ApplicationHandler interface. In 0.31.0 run_on_demand is removed. I've refactored both the integration and the WinitApp trait to follow this pattern. I've left user_events a bit more opaque, as it seems 0.31.0 is doing a rework of UserEvents too. - I've used the new lazy init approach for access kit from this branch https://github.com/mwcampbell/egui/tree/accesskit-new-lazy-init and marked Matt as co-author, thanks Matt! - There was very similair but not quite the same code for run_and_return and run_and_exit. I've merged them, but looking at the github issues graveyard it seems vey finnicky. I *hope* this is more robust than before but it's a bit scary. - when receiving new_events this also used to check the redraw timing dictionary. That doesn't seem necesarry so left this out, but that is a slight behaviour change? - I have reeneabled serial_windows on macOS. I wondered whether it was fixed after this PR and does seem to be! However, even before this PR it seems to work, so maybe winit has sorted things out before that... Windows also works fine now without the extra hack. - I've done a very basic test of AccessKit on Windows and screen reader seems ok but I'm really not knowleadgable enough to say whether it's all good or not. - I've tested cargo tests & all examples on Windows & macOS, and ran a basic Android app. Still, testing native platforms is wel... hard so if anyone can test linux / iOs / older mac versions / windows 10 would probably be a good idea! - For consistencys sake I've made all event like functions in WinitApp return a `Result<EventResult>`. There's quite a bit of Ok-wrapping now, maybe too annoying? Not sure. Thank you for having a look! # Tested on * [x] macOS * [x] Windows * [x] Wayland (thanks [SiebenCorgie](https://github.com/SiebenCorgie)) * [x] X11 (thanks [crumblingstatue](https://github.com/crumblingstatue)!, [SiebenCorgie](https://github.com/SiebenCorgie)) # TODO * [x] Fix "follow system theme" not working on initial startup (winit issue, pinning to 0.30.2 for now). * [x] Fix `request_repaint_after` --------- Co-authored-by: mwcampbell <mattcampbell@pobox.com> Co-authored-by: j-axa <josef.axa@gmail.com> Co-authored-by: DataTriny <datatriny@gmail.com> Co-authored-by: Emil Ernerfeldt <emil.ernerfeldt@gmail.com>

Bump winit to 0.30.0 and accesskit to 0.14.0

8a8f6ea

AndriBaal mentioned this pull request May 6, 2024

Update to winit 0.30 #4437

Closed

torokati44 mentioned this pull request May 6, 2024

build(deps): bump winit from 0.29.15 to 0.30.0 in the winit-wgpu-egui group ruffle-rs/ruffle#16145

Closed

emilk marked this pull request as draft May 6, 2024 14:27

emilk added eframe Relates to epi and eframe egui-winit porblems related to winit labels May 6, 2024

[FIX] Migrated winit to 0.30 for X11 and Wayland

6ecdf37

DataTriny mentioned this pull request May 27, 2024

High CPU usage when accesskit enabled #4527

Closed

attackgoat mentioned this pull request Jun 4, 2024

ash v0.38 support attackgoat/screen-13#75

Merged

5 tasks

Update glutin and glutin-winit to support winit 0.30, removed rwh_05 …

683c0b1

…and updated / implemented accesskit

AndriBaal closed this Jun 10, 2024

AndriBaal force-pushed the winit-0.30 branch from 683c0b1 to ca36f3d Compare June 10, 2024 15:04

Update glutin and glutin-winit to support winit 0.30, removed rwh_05 …

2c6e79a

…and updated / implemented accesskit

AndriBaal reopened this Jun 10, 2024

AndriBaal marked this pull request as ready for review June 10, 2024 16:38

Renamed all references to winit WindowBuilder to WindowAttributes

2235204

torokati44 mentioned this pull request Jun 13, 2024

build(deps): bump winit from 0.29.15 to 0.30.1 in the winit-wgpu-egui group across 1 directory ruffle-rs/ruffle#16672

Closed

emilk mentioned this pull request Jun 25, 2024

update winit to 0.30.3 #4702

Closed

emilk marked this pull request as draft July 15, 2024 09:17

ArthurBrussee mentioned this pull request Jul 18, 2024

Upgrade winit to 0.30.2 #4849

Merged

7 tasks

emilk closed this Jul 31, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bump winit to 0.30.0 and accesskit to 0.14.0 #4466

Bump winit to 0.30.0 and accesskit to 0.14.0 #4466

AndriBaal commented May 6, 2024 •

edited by emilk

Loading

Babakinha commented Jun 9, 2024

AndriBaal commented Jun 10, 2024 •

edited

Loading

DataTriny commented Jun 10, 2024 •

edited

Loading

AndriBaal commented Jun 10, 2024 •

edited

Loading

DataTriny commented Jun 10, 2024

emilk commented Jul 31, 2024

Bump winit to 0.30.0 and accesskit to 0.14.0 #4466

Bump winit to 0.30.0 and accesskit to 0.14.0 #4466

Conversation

AndriBaal commented May 6, 2024 • edited by emilk Loading

Babakinha commented Jun 9, 2024

AndriBaal commented Jun 10, 2024 • edited Loading

DataTriny commented Jun 10, 2024 • edited Loading

AndriBaal commented Jun 10, 2024 • edited Loading

DataTriny commented Jun 10, 2024

emilk commented Jul 31, 2024

AndriBaal commented May 6, 2024 •

edited by emilk

Loading

AndriBaal commented Jun 10, 2024 •

edited

Loading

DataTriny commented Jun 10, 2024 •

edited

Loading

AndriBaal commented Jun 10, 2024 •

edited

Loading